summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGuido Günther <agx@sigxcpu.org>2013-04-29 14:31:37 +0200
committerGuido Günther <agx@sigxcpu.org>2013-04-29 14:31:37 +0200
commitc77843aa8837424a4fbe343d8ce909f33acc8a0e (patch)
tree6063c5a33bfd172516906c3dffdfc1ddb602e1cb
parent0c582cd827f164168a313e0bb4eabf9487bdd088 (diff)
Revert "Use Popen.communicate instead of subprocess call"
This reverts commit 0c582cd827f164168a313e0bb4eabf9487bdd088.
-rw-r--r--gbp/command_wrappers.py7
1 files changed, 0 insertions, 7 deletions
diff --git a/gbp/command_wrappers.py b/gbp/command_wrappers.py
index 8dba707e..47ad27be 100644
--- a/gbp/command_wrappers.py
+++ b/gbp/command_wrappers.py
@@ -50,7 +50,6 @@ class Command(object):
else:
self.env = None
- # FIXME: should we make this similiar to __git_inout ?
def __call(self, args):
"""
Wraps subprocess.call so we can be verbose and fix python's
@@ -65,12 +64,6 @@ class Command(object):
if self.shell:
# subprocess.call only cares about the first argument if shell=True
cmd = " ".join(cmd)
- popen = subprocess.Popen(cmd,
- cwd=self.cwd,
- shell=self.shell,
- preexec_fn=default_sigpipe,
- stderr=subprocess.PIPE)
- (dummy, stderr) = popen.communicate(input)
return subprocess.call(cmd, cwd=self.cwd, shell=self.shell,
env=self.env, preexec_fn=default_sigpipe)