From 21c89cae6918d548f9ed7883f9a12b742c414497 Mon Sep 17 00:00:00 2001 From: Guido Günther Date: Tue, 10 Jan 2017 19:24:58 +0100 Subject: UpstreamSource: don't use empty list as default argument since we want to avoid the same list being reused --- gbp/pkg/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gbp/pkg/__init__.py b/gbp/pkg/__init__.py index 75975b1c..70bcb21e 100644 --- a/gbp/pkg/__init__.py +++ b/gbp/pkg/__init__.py @@ -309,7 +309,7 @@ class UpstreamSource(object): def path(self): return self._path.rstrip('/') - def unpack(self, dir, filters=[]): + def unpack(self, dir, filters=None): """ Unpack packed upstream sources into a given directory (filtering out files specified by filters) and determine the @@ -368,7 +368,7 @@ class UpstreamSource(object): # unpackArchive already printed an error message raise GbpError - def pack(self, newarchive, filters=[]): + def pack(self, newarchive, filters=None): """ Recreate a new archive from the current one -- cgit v1.2.3