[PATCH] Release priv->mtx when registering network device

Not doing so causes circular mutex dependency, which is detected by the
kernel lock validation code  The driver's mutex should only protect
hardware access and driver's structures, and should not be held when
dealing with higher layers of the kernel.

The locking and the initialization may need a serious overhaul, but this
little change is a step in the right direction.

Signed-off-by: Pavel Roskin <proski@gnu.org>

1 files changed, 2 insertions, 0 deletions

diff --git a/at76_usb.c b/at76_usb.c
index 58bddd7..10da864 100644
--- a/at76_usb.c
+++ b/at76_usb.c
@@ -4296,8 +4296,10 @@ static void at76_work_external_fw(struct work_struct *work)
 		}
 	}
 	priv->istate = INIT;
+	mutex_unlock(&priv->mtx);
 	if ((ret = at76_init_new_device(priv)) < 0)
 		err("Downloading external firmware failed: %d", ret);
+	return;
 
   end_external_fw:
 	mutex_unlock(&priv->mtx);